does will ferrell get royalties for elf

Actually, yes! The film's producer, Jon Berg, and director, Jon Favreau, recognized the importance of his character, and they actually made a deal with Will Ferrell. He gets a portion of the film's profits, and he also received a bonus for his performance. So, yes, Will Ferrell does get royalties for "Elf".