who wrote twelve days of christmas

That would be the English lyricist Robert L. Mayhew. He wrote the lyrics to "Twelve Days of Christmas" in 1780, as a way to teach children the different gifts in the song. The original song actually had 24 days, but it was shortened to 12 days in order to make it more manageable. The song has become a Christmas classic, and is still sung by many people today.